[ 
https://issues.apache.org/jira/browse/CASSANDRA-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915481#action_12915481
 ] 

Stu Hood commented on CASSANDRA-1434:
-------------------------------------

This patch includes a change CompactionManager.java.

>> There is a race condition in put() between !run and the put itself
> not really. the check in put is just an attempt to abort earlier if possible.
put() is called from the parent thread: it isn't interrupted by the child 
thread, so it will block indefinitely if an exception occurs between 
lastException != null and the blocking put(). Unlikely, but...

----

Other than those two nitpicks, +1: tested against a 12 node cluster and saw 
smooth network utilization.

> ColumnFamilyOutputFormat performs blocking writes for large batches
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-1434
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1434
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Hadoop
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>             Fix For: 0.7.0
>
>         Attachments: 
> 0001-Switch-away-from-Multimap-and-fix-regression-introdu.patch, 
> 0002-Improve-concurrency-and-add-basic-retries-by-attempt.patch, 
> 0003-Switch-RingCache-back-to-multimap.patch, 
> 0004-Replace-Executor-with-map-of-threads.patch, 1434-v3.txt, 1434-v4.txt, 
> 1434-v5.txt, 1434-v6.txt
>
>
> By default, ColumnFamilyOutputFormat batches 
> {{mapreduce.output.columnfamilyoutputformat.batch.threshold}} or 
> {{Long.MAX_VALUE}} mutations, and then performs a blocking write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to