[
https://issues.apache.org/jira/browse/CASSANDRA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918582#action_12918582
]
Jonathan Ellis commented on CASSANDRA-1546:
-------------------------------------------
bq. While this is not untrue, the code you are mentioning is simpler than the
complex counter manipulation and I think, has a strong cassandra flavor.
I agree. I think we've entered the realm of subjectivity here, so as my
personal opinion, 1072 feels like a separate database that happens to use parts
of cassandra internals. I feel comfortable committing to maintain 1546 in a
way that I never did with 1072, in large part because there are so many fewer
special cases that need to be handled (AES, streaming, decrement, )
bq. The other challenge is that the existing cassandra data model is co-opted,
so the end user has to learn a modified data model that is counter-specific. I
don't believe this is the right encapsulation.
Again subjectively, I think leveraging the existing data model under the hood
is a Good Thing. I believe this is directly responsible for the relative lack
of need for special case handling with this approach.
I don't understand the end-user/encapsulation argument. I may be missing
something again, but either way we are talking about providing add() and
get_counter() methods or their equivalent, no? The end user just deals with
Counter structs and doesn't have to care about the implementation.
Can 1546 meet Twitter's business needs? IMO that is the most important
question.
> (Yet another) approach to counting
> ----------------------------------
>
> Key: CASSANDRA-1546
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1546
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.7.0
>
> Attachments: 0001-Remove-IClock-from-internals.patch,
> 0001-v2-Remove-IClock-from-internals.patch,
> 0001-v3-Remove-IClock-from-internals.patch, 0002-Counters.patch,
> 0002-v2-Counters.patch, 0002-v3-Counters.patch,
> 0003-Generated-thrift-files-changes.patch, 0003-v2-Thrift-changes.patch,
> 0003-v3-Thrift-changes.patch, marker_idea.txt
>
>
> This could be described as a mix between CASSANDRA-1072 without clocks and
> CASSANDRA-1421.
> More details in the comment below.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
