[ 
https://issues.apache.org/jira/browse/CASSANDRA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918969#action_12918969
 ] 

Kelvin Kakugawa commented on CASSANDRA-1546:
--------------------------------------------

Yes, I agree that my arguments for comparative space efficiency are partly 
speculative.  Eventually, I may directly manage the memory for those byte 
arrays.  And, as you point out, there are parts of #1072 that still can be 
improved.

Splitting out the partitioned counter into separate columns allows less data to 
be replicated.  You're right, on write, it requires only transferring the 
leader's updated count.  #1072 could be modified to do this, as well.  As you 
point out, it's only the leader's updated count that matters, and a #1072 
column will create the same resultant column on receipt of just the leader's 
updated count.

cleanContext may benefit from another audit of the code and strategy.  I agree 
w/ you that it's not a strategy in the code that I'm the most proud of.

The AES changes do need to be more invasive than it would first appear.  ÅES 
streaming directly streams the data file over; it does not deserialize or 
transform the data file.  It only rebuilds the index and filter files--the data 
file is not touched.  If you have an approach to refactor #1072's AES code 
path, I would be more than happy to adopt your approach.  Since, the 
transformation that #1072 has to perform is abstractly equivalent to the 
transformation that #1546 needs.

> (Yet another) approach to counting
> ----------------------------------
>
>                 Key: CASSANDRA-1546
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1546
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.7.0
>
>         Attachments: 0001-Remove-IClock-from-internals.patch, 
> 0001-v2-Remove-IClock-from-internals.patch, 
> 0001-v3-Remove-IClock-from-internals.txt, 0002-Counters.patch, 
> 0002-v2-Counters.patch, 0002-v3-Counters.txt, 
> 0003-Generated-thrift-files-changes.patch, 0003-v2-Thrift-changes.patch, 
> 0003-v3-Thrift-changes.txt, marker_idea.txt
>
>
> This could be described as a mix between CASSANDRA-1072 without clocks and 
> CASSANDRA-1421.
> More details in the comment below.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to