[
https://issues.apache.org/jira/browse/CASSANDRA-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923103#action_12923103
]
Jonathan Ellis commented on CASSANDRA-1263:
-------------------------------------------
bq. We need to make sure they give us a replication_factor.
Right.
bq. We should not verify arbitrary key/values in strategy_opts because that is
FAR messier than the current solution
Wrong. strategy_ops is by definition he only place for per-strategy options,
and replication_factor is already a per-strategy option. The problem is the
current KsDef doesn't acknowledge that yet. This is a bug.
Classes implementing ARS should take whatever replication configuration
necessary from strategy_options and store that state at construction time, the
way NTS already does.
ReplicationFactor is an implementation detail of some strategies, NOT something
we should expose as integral to all of them because we have proof that it's
not. If you look at the code the only references it outside the Strategy
classes themselves are a couple assert statements that could easily be cleaned
up.
> Push replication factor down to the replication strategy
> --------------------------------------------------------
>
> Key: CASSANDRA-1263
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1263
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.0
>
>
> Currently the replication factor is in the keyspace metadata. As we've added
> the datacenter shard strategy, the replication factor becomes more computed
> by the replication strategy. It seems reasonable to therefore push the
> replication factor for the keyspace down to the replication strategy so that
> it can be handled in one place.
> This adds on the work being done in CASSANDRA-1066 since that ticket will
> make the replication strategy a member variable of keyspace metadata instead
> of just a quasi singleton giving the replication strategy state for each
> keyspace. That makes it able to have the replication factor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
