[
https://issues.apache.org/jira/browse/CASSANDRA-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924589#action_12924589
]
Pavel Yaskevich commented on CASSANDRA-615:
-------------------------------------------
please review before somebody made big changes to the CliClient.java again :)
> refactor o.a.c.cli.CliClient
> ----------------------------
>
> Key: CASSANDRA-615
> URL: https://issues.apache.org/jira/browse/CASSANDRA-615
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Eric Evans
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments: CASSANDRA-615.patch
>
>
> There is a lot of code duplication when it comes to decomposing commands into
> keyspace, column family, keys, columns, etc, and validating the results.
> There would be even more if the error handling was more thorough.
> I think the cleanest way is to create a class that accepts a CommonTree in
> its constructor and assigns the results to members. A custom exception can be
> thrown for validation errors and CliClient can simply trap these, print the
> descriptive .msg, and return.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
