[
https://issues.apache.org/jira/browse/CASSANDRA-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137866#comment-14137866
]
Yuki Morishita commented on CASSANDRA-7932:
-------------------------------------------
I'm +1 for this to be in 2.1.
LGTM overall, though I'm seeing the following from output of
ColumnFamilyStoreTest:
{noformat}
ERROR 19:41:53 Fatal exception in thread Thread[NonPeriodicTasks:1,5,main]
java.lang.NullPointerException: null
at
org.apache.cassandra.io.sstable.SSTableReader$Tidier$1.run(SSTableReader.java:1993)
~[main/:na]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
~[na:1.7.0_51]
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
~[na:1.7.0_51]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
~[na:1.7.0_51]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
~[na:1.7.0_51]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
~[na:1.7.0_51]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[na:1.7.0_51]
at java.lang.Thread.run(Thread.java:744) [na:1.7.0_51]
{noformat}
Nits:
* There is unused AbstractRefCounted class
* You can use {{@Test(expected = IllegalStateException.class)}} for the last
test in RefCountedTest.
> Corrupt SSTable Cleanup Leak Resources
> --------------------------------------
>
> Key: CASSANDRA-7932
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7932
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 2.1.1
>
>
> CASSANDRA-7705, during the BlackingListingCompactionsTest, detected leaks.
> I've tracked this down to DataTracker.removeUnreadableSSTables() , which does
> not release the reference to any sstables from the tracker.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)