[
https://issues.apache.org/jira/browse/CASSANDRA-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-7719:
-----------------------------------------
Attachment: 7719-followup.txt
Attaching a follow up patch, that
- fixes the prepared statements count to be a gauge that simply sums up the
values of thrift/native prepared statement caches
- makes the ratio calculate the ratio or prepared to total, instead of prepared
to regular (don't need to handle 0 in getDenominator(), b/c the gauge handles
that and would simply return NaN then)
- removes logger.trace() calls from QP#storePreparedStatement()
- renames a bunch of stuff for consistency with the rest of our metrics code
I've left empty onEviction() callbacks instead of removing them entirely - for
CASSANDRA-7930 purposes.
> Add PreparedStatements related metrics
> --------------------------------------
>
> Key: CASSANDRA-7719
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7719
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Michaël Figuière
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 2.1.1
>
> Attachments: 7719-followup.txt, 7719.txt
>
>
> Cassandra newcomers often don't understand that they're expected to use
> PreparedStatements for almost all of their repetitive queries executed in
> production.
> It doesn't look like Cassandra currently expose any PreparedStatements
> related metrics.It would be interesting, and I believe fairly simple, to add
> several of them to make it possible, in development / management / monitoring
> tools, to show warnings or alerts related to this bad practice.
> Thus I would suggest to add the following metrics:
> * Executed prepared statements count
> * Executed unprepared statements count
> * Amount of PreparedStatements that have been registered on the node
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
