Marcus Eriksson created CASSANDRA-8034:
------------------------------------------

             Summary: AssertionError when STOP:ing compactions
                 Key: CASSANDRA-8034
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8034
             Project: Cassandra
          Issue Type: Bug
            Reporter: Marcus Eriksson
             Fix For: 2.1.1


When we open compaction results early we clone the SSTableReader (ie create a 
new instance of it). Any compaction strategy that keeps track of its sstables 
will not be notified of that new sstable and keeps a reference to the old 
instance. The compaction strategy gets notified when the compaction is actually 
done.

The problem is if the compaction is interrupted, then LCS will start a new 
compaction with those stale SSTableReader instances and trigger an assertion 
error:

{code}
ERROR 14:27:06 Exception in thread Thread[CompactionExecutor:3,1,main]
java.lang.AssertionError: Reference counter -1 for 
/var/lib/cassandra/data/Keyspace1/Standard1-0bf25ed0496711e4bf3f07871b385ea9/Keyspace1-Standard1-ka-15-Data.db
        at 
org.apache.cassandra.io.sstable.SSTableReader.releaseReference(SSTableReader.java:1601)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.db.DataTracker.replaceReaders(DataTracker.java:375) 
~[Cassandra/:na]
        at 
org.apache.cassandra.io.sstable.SSTableRewriter.replaceReaders(SSTableRewriter.java:284)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.io.sstable.SSTableRewriter.moveStarts(SSTableRewriter.java:250)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:298)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:187)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
~[Cassandra/:na]
        at 
org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:75)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
 ~[Cassandra/:na]
        at 
org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:236)
 ~[Cassandra/:na]
        at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) 
~[na:1.7.0_67]
        at java.util.concurrent.FutureTask.run(FutureTask.java:262) 
~[na:1.7.0_67]
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 
~[na:1.7.0_67]
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 
[na:1.7.0_67]
        at java.lang.Thread.run(Thread.java:745) [na:1.7.0_67]
{code}

Fix is probably to tell the compaction strategy that there is a new sstable 
instance whenever we create one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to