[
https://issues.apache.org/jira/browse/CASSANDRA-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164372#comment-14164372
]
Joshua McKenzie commented on CASSANDRA-7838:
--------------------------------------------
Tested on Windows and Sigar failed to initialize. I've rebased to trunk and
made a few changes [available
here|https://github.com/josh-mckenzie/cassandra/compare/7838_trunk]
Quick summary:
* rebased to trunk
* Fixed %VAR% instead of $VAR on cassandra.in.bat
* Added -D option to JVM_OPTS in cassandra.bat for sigar launch on
non-powershell environments
* Added -D option to JVM_OPTS in conf\cassandra-env.ps1 for powershell
environments
* Skip the AddressSpace check on Windows (always returning int max + 1 for
whatever reason...?)
* Cleaned up some formatting inconsistencies in SigarLibrary.java
* Tidied up the naming in SigarLibrary.java in general (fixed abbreviations
like As for AddressSpace, for instance)
* Changed from using Result enum to booleans and warn if we fail to query any
of the metrics, also reporting a degraded environment if we can't query anything
In your previous implementation you reported that everything was fine even if
we got a Result.UNK, and it would probably be helpful to log which queries
failed so admins can go in and resolve that and get the extra information. A
potential downside here is that it's a little aggressive to report that we're
degraded just because we got a failure to query, but if we're committed to
adding Sigar to the code-base I think we should be committed to these queries
working. :)
LGTM on the Windows side from here.
> Warn user when OS settings are poor / integrate sigar
> -----------------------------------------------------
>
> Key: CASSANDRA-7838
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7838
> Project: Cassandra
> Issue Type: Improvement
> Reporter: T Jake Luciani
> Assignee: AMIT KUMAR
> Priority: Minor
> Labels: bootcamp, lhf
> Fix For: 3.0
>
> Attachments:
> 0005-CASSANDRA-7838-log-warning-for-networked-drives.patch,
> 0006-added-missing-winnt-native.patch,
> 0007-CASSANDRA-7838-WIP-adding-a-few-other-checks.patch,
> 0008-CASSANDRA-7838-Removed-network-check-and-read-latenc.patch,
> 0009-Bug-fix-swap-check-was-incorrect-fixed-logging-state.patch,
> 0010-Minor-log-change-happy-path.patch
>
>
> The Sigar project let's you probe os/cpu/filesystems across the major
> platforms.
> https://github.com/hyperic/sigar
> It would be nice on start-up to use this to warn users if they are running
> with settings that will make them sad, like Network drive or EBS on Ec2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
