[
https://issues.apache.org/jira/browse/CASSANDRA-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-8145:
---------------------------------------
Attachment: 8145.txt
Patch reverts the access modifier on QueryProcessor#processStatement() and also
makes it an instance method.
Also, as calling processStatement directly doesn't increment the new metrics
introduced in CASSANDRA-7719, QueryHandler implementations must take
responsiblity for doing so when they make the call. The QueryProcessor.metrics
is already public, so this is possible but I've replaced the @VisibleForTesting
annotation with a comment.
> Restore public access to QueryProcessor#processStatement
> --------------------------------------------------------
>
> Key: CASSANDRA-8145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8145
> Project: Cassandra
> Issue Type: Bug
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
> Attachments: 8145.txt
>
>
> Classes which implement the QueryHandler interface were previously able to
> delegate to QueryProcessor#getStatement() and
> QueryProcessor#processStatement() which allowed them to inspect the parsed
> statement objects before execution. CASSANDRA-7719 made
> QueryProcessor#processStatement() private, so a custom QueryHandler is now
> forced to call QueryProcess#process and have the parsing performed twice.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
