[
https://issues.apache.org/jira/browse/CASSANDRA-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180173#comment-14180173
]
Benjamin Lerer commented on CASSANDRA-7927:
-------------------------------------------
2 minor nits for me:
* As {{JVMStabilityInspector}} as only static methods and instances, I would
have make it final with a private constructor.
* Personally I prefer to separate test related classes from production classes
so I would have put KillerForTests with the tests but it is a matter of taste.
Otherwise it is a +1 for me.
> Kill daemon on any disk error
> -----------------------------
>
> Key: CASSANDRA-7927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7927
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Environment: aws, stock cassandra or dse
> Reporter: John Sumsion
> Assignee: John Sumsion
> Labels: bootcamp, lhf
> Fix For: 2.1.2
>
> Attachments: 7927-v1-die.patch
>
>
> We got a disk read error on 1.2.13 that didn't trigger the disk failure
> policy, and I'm trying to hunt down why, but in doing so, I saw that there is
> no disk_failure_policy option for just killing the daemon.
> If we ever get a corrupt sstable, we want to replace the node anyway, because
> some aws instance store disks just go bad.
> I want to use the JVMStabilityInspector from CASSANDRA-7507 to kill so that
> remains standard, so I will base my patch on CASSANDRA-7507.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
