[
https://issues.apache.org/jira/browse/CASSANDRA-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188482#comment-14188482
]
Joshua McKenzie commented on CASSANDRA-8171:
--------------------------------------------
Might want a trivial comment on intention of package-private on 'final C token'
in AbstractToken - can add on commit. The reduction in noise surrounding
generics on Token is particularly nice - TokenFactory's are a lot cleaner now.
Reducing 1/4 of our warnings is a great step - I'm +1 on us investigating
moving to a "warning as error" paradigm on builds down the road someday;
perhaps we should consider adding a build target w/warnings shown on a separate
ticket? (Assuming we don't already have this and I'm just missing it in the
build.xml...)
I'm +1 on commit as-is. [~jbellis]: 2.1.2 or 3.0? It's a pretty
straightforward refactor which leans me toward 2.1.2 but it's also dealing with
some fundamental primitives of the system. I'm on the fence.
> Clean up generics
> -----------------
>
> Key: CASSANDRA-8171
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8171
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Branimir Lambov
> Assignee: Branimir Lambov
> Priority: Minor
> Attachments: 8171.patch
>
>
> Some uses of generics in the code are causing much more harm than good, and
> in some cases generic types are used unsafely, hiding potential problems in
> the code.
> Generics need to be cleaned up to clarify the types, remove unnecessary type
> specialization when it does not make sense, and significantly reduce the
> number of unhelpful warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
