[
https://issues.apache.org/jira/browse/CASSANDRA-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219526#comment-14219526
]
Joshua McKenzie commented on CASSANDRA-8244:
--------------------------------------------
getHeapSize on BigIntegerToken has a 'TODO: Probably wrong' comment for
getHeapSize(). While I agree, we should probably either fix that or create
another ticket to address that and maybe reference it in the comment.
nits:
* annotate @VisibleForTesting on
RandomPartitioner.BigIntegerToken.BigIntegerToken(String token)
* clean up import order on FBUtilities.java
* looks like changes to a couple of the .db files under test snuck in on commit
Looks good - nice cleanup!
> Token, DecoratedKey, RowPosition and all bound types should not make any
> hidden references to the database partitioner
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-8244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8244
> Project: Cassandra
> Issue Type: Bug
> Reporter: Branimir Lambov
> Assignee: Branimir Lambov
> Priority: Minor
> Fix For: 3.0
>
>
> Currently some of the functionality of Token refers to
> StorageService.getPartitioner() to avoid needing an extra argument. This is
> in turn implicitly used by RowPosition and then Range, causing possible
> problems, for example when ranges on secondary indices are used in a
> murmur-partitioned database.
> These references should be removed to force explicit choice of partitioner by
> callers; alternatively, the Token interface could be changed to provide a
> reference to the partitioner that created it.
> (Note: the hidden reference to partitioner in serialization is a separate
> issue.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
