[ 
https://issues.apache.org/jira/browse/CASSANDRA-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244552#comment-14244552
 ] 

Joshua McKenzie commented on CASSANDRA-8452:
--------------------------------------------

The failure / check on maybeReopenEarly isn't about whether it's posix or not 
but about whether it's ntfs (and pre-nio technically, though we're 
all-or-nothing windows on 2.1).  Is there a reason we shouldn't reduce this to 
isWindows and hasProcFS checks and move forward with the assumption of 
posix-compliance if not Windows, given the platforms we run on?

Seems unnecessary to have the isPosix structure simply to add that to the check 
on the fs for proc.

> Add missing systems to FBUtilities.isUnix, add FBUtilities.isWindows
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-8452
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8452
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 2.1.3
>
>         Attachments: CASSANDRA-8452-v2.patch, CASSANDRA-8452-v3.patch, 
> CASSANDRA-8452.patch
>
>
> The isUnix method leaves out a few unix systems, which, after the changes in 
> CASSANDRA-8136, causes some unexpected behavior during shutdown. It would 
> also be clearer if FBUtilities had an isWindows method for branching into 
> Windows specific logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to