[
https://issues.apache.org/jira/browse/CASSANDRA-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
T Jake Luciani updated CASSANDRA-1470:
--------------------------------------
Attachment: CASSANDRA-1470-v7-for-0.7.patch
I ran the v6 patch on OSX and linux, found a few issues :
1. OSX never logs that mlockall succeeds.
2. No testcase for directio BRAF
3. BRAF.sync() accesses .array() which is not allowed in directio mode
4. (minor) Under Linux BRAF test testOverflowMark fails with:
_java.lang.Exception: Unexpected exception,
expected<java.lang.UnsupportedOperationException> but was<java.io.IOException>_
_[junit] Caused by: java.io.IOException: Invalid argument_
Don't think it's a big deal but probably JDK impl?
5. (minor) BRAF uses "this." all over the place to access member vars which is
against the style guide.
I've attached v7 which addresses 1-4, once applied the code worked for me,
though I haven't yet compared the difference in read performance during
compaction (tomorrow?)
> use direct io for compaction
> ----------------------------
>
> Key: CASSANDRA-1470
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1470
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: 1470-v2.txt, 1470.txt, CASSANDRA-1470-for-0.6.patch,
> CASSANDRA-1470-v2.patch,
> CASSANDRA-1470-v3-0.7-with-LastErrorException-support.patch,
> CASSANDRA-1470-v4-for-0.7.patch, CASSANDRA-1470-v5-for-0.7.patch,
> CASSANDRA-1470-v6-for-0.7.patch, CASSANDRA-1470-v7-for-0.7.patch,
> CASSANDRA-1470.patch,
> use.DirectIORandomAccessFile.for.commitlog.against.1022235.patch
>
>
> When compaction scans through a group of sstables, it forces the data in the
> os buffer cache being used for hot reads, which can have a dramatic negative
> effect on performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
