[
https://issues.apache.org/jira/browse/CASSANDRA-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260076#comment-14260076
]
Jimmy Mårdell commented on CASSANDRA-8414:
------------------------------------------
Hi,
Thanks for your comments!
v4 uploaded which fixes your comments. I also added the batch iterator to
CFS.removeDroppedColumns() as that was easy enough, but skipped
SliceQueryFilter for now.
> Avoid loops over array backed iterators that call iter.remove()
> ---------------------------------------------------------------
>
> Key: CASSANDRA-8414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8414
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Richard Low
> Assignee: Jimmy Mårdell
> Labels: performance
> Fix For: 2.1.3
>
> Attachments: cassandra-2.0-8414-1.txt, cassandra-2.0-8414-2.txt,
> cassandra-2.0-8414-3.txt, cassandra-2.0-8414-4.txt
>
>
> I noticed from sampling that sometimes compaction spends almost all of its
> time in iter.remove() in ColumnFamilyStore.removeDeletedStandard. It turns
> out that the cf object is using ArrayBackedSortedColumns, so deletes are from
> an ArrayList. If the majority of your columns are GCable tombstones then this
> is O(n^2). The data structure should be changed or a copy made to avoid this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
