[
https://issues.apache.org/jira/browse/CASSANDRA-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275869#comment-14275869
]
Tyler Hobbs commented on CASSANDRA-8558:
----------------------------------------
+1 with a few nits:
* In {{IndexSliceReader.fetchMoreData()}}, it seems like {{gotSome}} should
only be set to true if we read a non-RangeTombstone. However, that's a minor
optimization (if I'm correct) and shouldn't affect correctness, so I won't
block the patch for that.
* In the 2.1 patch, {{nextKind}} is a bit of a strange name. I suggest
{{nextFlags}} instead.
* {{CellNameType.readNextFully()}} is also a confusing name. It seems like
{{nextNameIsNotEmpty()}} would be more accurate?
* In the 2.0 patch, indentation is off for the comments in the last two hunks
* A couple of typos: "maskes" in AtomDeserializer, "prefecthed" in
IndexSliceReader (2.1 patch),
> deleted row still can be selected out
> -------------------------------------
>
> Key: CASSANDRA-8558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8558
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Environment: 2.1.2
> java version "1.7.0_55"
> Reporter: zhaoyan
> Assignee: Sylvain Lebresne
> Priority: Blocker
> Fix For: 2.0.12, 2.1.3
>
> Attachments: 8558-v2_2.0.txt, 8558-v2_2.1.txt, 8558.txt
>
>
> first
> {code}CREATE KEYSPACE space1 WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 3};
> CREATE TABLE space1.table3(a int, b int, c text,primary key(a,b));
> CREATE KEYSPACE space2 WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 3};{code}
> second
> {code}CREATE TABLE space2.table1(a int, b int, c int, primary key(a,b));
> CREATE TABLE space2.table2(a int, b int, c int, primary key(a,b));
> INSERT INTO space1.table3(a,b,c) VALUES(1,1,'1');
> drop table space2.table1;
> DELETE FROM space1.table3 where a=1 and b=1;
> drop table space2.table2;
> select * from space1.table3 where a=1 and b=1;{code}
> you will find that the row (a=1 and b=1) in space1.table3 is not deleted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
