[ 
https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282184#comment-14282184
 ] 

Sachin Janani edited comment on CASSANDRA-8348 at 1/22/15 2:00 PM:
-------------------------------------------------------------------

I am taking up this jira.I would like to propose following 2 approaches:
1) To provide ks.cf list in the already available option -cf 
                This approach will take the following types of arguments:

                        e.g: nodetool snapshot -cf ks1.cf1 ks2.cf3 ks4.*

                        The above command will take snapshot of column family 
cf1 from keyspace ks1 and cf3 from keyspace ks2 and all column families from 
keyspace ks4 

                Pros:
                        No need to add extra option
                        Existing keyspace option will be obsolete
                        
                Cons:
                        Users may need to change their existing scripts and -cf 
will no longer support only column family name
                        
                        
2) To provide separate option to accept keyspace.columnfamily list:
                This approach will add a new option which will take following 
parameters:

                        e.g nodetool -kclist ks1.cf1,ks2.cf2,ks2.cf3
                        
                     The above command will take snapshot of column family cf1 
from keyspace ks1 and cf3 from keyspace ks2 
                        
                Pros:
                        Will support existing option so no need to change 
existing scripts
                        Will help to take snapshot of multiple columnfamily 
from different keyspace in one go
                Cons:
                        Need to add extra option
                        
Can anyone please suggest the approach that I should follow or if you have some 
different approach please let me know.


was (Author: sachinjanani):
I am taking up this jira.I would like to propose following 2 approaches:
1) To provide ks.cf list in the already available option -cf 
                This approach will take the following types of arguments:

                        e.g: nodetool snapshot -cf ks1.cf1 ks2.cf3 ks4.*

                        The above command will take snapshot of column family 
cf1 from keyspace ks1 and cf3 from keyspace ks2 and all column families from 
keyspace ks4 

                Pros:
                        No need to add extra option
                        Existing keyspace option will be obsolete
                        
                Cons:
                        Users may need to change their existing scripts and -cf 
will no longer support only column family name
                        
                        
2) To provide separate option to accept keyspace.columnfamily list:
                This approach will add a new option which will take following 
parameters:

                        e.g nodetool -kclist ks1.cf1 ks2.cf2 ks2.cf3 ks4.*
                        
                     The above command will take snapshot of column family cf1 
from keyspace ks1 and cf3 from keyspace ks2 and all column families from 
keyspace ks4 
                        
                Pros:
                        Will support existing option so no need to change 
existing scripts
                        Will help to take snapshot of multiple columnfamily 
from different keyspace in one go
                Cons:
                        Need to add extra option
                        
Can anyone please suggest the approach that I should follow or if you have some 
different approach please let me know.

> allow takeColumnFamilySnapshot to take a list of ColumnFamilies
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-8348
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Peter Halliday
>            Priority: Minor
>             Fix For: 3.0, 2.1.3
>
>
> Within StorageServiceMBean.java the function takeSnapshot allows for a list 
> of keyspaces to snapshot.  However, the function takeColumnFamilySnapshot 
> only allows for a single ColumnFamily to snapshot.  This should allow for 
> multiple ColumnFamilies within the same Keyspace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to