[
https://issues.apache.org/jira/browse/CASSANDRA-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328244#comment-14328244
]
Ariel Weisberg edited comment on CASSANDRA-8692 at 2/19/15 10:43 PM:
---------------------------------------------------------------------
To me the way it reads is that the caller wants the collection to not be filled
with more than outSize elements. If they pass in a non-empty collection it is
fine with me. The caller probably did make a mistake.
I would be more comfortable with adding a precondition rather than trying to
reason about how many elements are in the collection. It's fragile in the face
of changes and copy pasta.
was (Author: aweisberg):
To me the way it reads is that the caller wants the collection to not be filled
with more then outSize elements. If they pass in a non-empty collection it is
fine with me. The caller probably did make a mistake.
I would be more comfortable with adding a precondition rather than trying to
reason about how many elements are in the collection. It's fragile in the face
of changes and copy pasta.
> Coalesce intra-cluster network messages
> ---------------------------------------
>
> Key: CASSANDRA-8692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8692
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Ariel Weisberg
> Assignee: Ariel Weisberg
> Fix For: 2.1.4
>
> Attachments: batching-benchmark.png
>
>
> While researching CASSANDRA-8457 we found that it is effective and can be
> done without introducing additional latency at low concurrency/throughput.
> The patch from that was used and found to be useful in a real life scenario
> so I propose we implement this in 2.1 in addition to 3.0.
> The change set is a single file and is small enough to be reviewable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
