[
https://issues.apache.org/jira/browse/CASSANDRA-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339391#comment-14339391
]
Ariel Weisberg commented on CASSANDRA-8757:
-------------------------------------------
I didn't understand the offset business so the comment probably doesn't provide
the right context. After agonizing for a while I figured out what it meant. It
could be lack of sleep.
It might be clearer if it described the mismatch between in memory and on disk
(in a way I grok). The in-memory representation is a set of offsets into a
separate zero indexed array while the disk based representation is a set of
offsets to entries appended after the offsets section so every offset needs to
be recalculated.
I think "serialization point" didn't parse for me as being the point in the
file after the offsets.
{quote}
because we serialize/deserialize in native
+ // int/long format,
{quote}
And that doesn't seem to be the cause of this mess. It's not the native
int/long formatness of it. It's that the offsets are into array and the two
have to be flattened into one file.
SSTableReader line 747 random semi-colon, IndexSummaryBuilder line 216 extra
semi-colon.
SafeMemoryWriter has no unit test.
Otherwise I am +1
> IndexSummaryBuilder should construct itself offheap, and share memory between
> the result of each build() invocation
> -------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-8757
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8757
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 2.1.4
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
