[
https://issues.apache.org/jira/browse/CASSANDRA-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348391#comment-14348391
]
Stefania commented on CASSANDRA-8236:
-------------------------------------
I have the following comments, one one of which trivial:
\\
\\
* {{VersionedValue.RPC_READY}} doesn't seemed to be used
* In SS.{{handleStateNormal()}}, why do we need to call {{notifyJoined()}} even
when {{isMoving}} is set to true? Wouldn't this introduce problems similar to
CASSANDRA-8516?
* In {{ApplicationState}} can we add a new value without removing one of the
padding values?
Having worked on CASSANDRA-8516, I somehow feel we are doing this the hard way.
Shouldn't we perhaps just add a new {{ApplicationState}} called TOPOLOGY_CHANGE
that contains the {{Event.TopologyChange}} value that a node wants a client to
receive? This way a node controls what clients receive and when. I'd be happy
to work on this but can you confirm if this would be a valid approach both for
this ticket and for CASSANDRA-8516?
[~thobbs] and [~brandon.williams] what do you think?
> Delay "node up" and "node added" notifications until native protocol server
> is started
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-8236
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8236
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tyler Hobbs
> Assignee: Brandon Williams
> Fix For: 3.0
>
> Attachments: 8236.txt
>
>
> As discussed in CASSANDRA-7510, there is still a gap between when a "node up"
> or "node added" notification may be sent to native protocol clients (in
> response to a gossip event) and when the native protocol server is ready to
> serve requests.
> Everything in between the call to {{StorageService.instance.initServer()}}
> and creation of the native server in {{CassandraDaemon.setup()}} contributes
> to this delay, but waiting for Gossip to settle introduces the biggest delay.
> We may need to introduce a "STARTING" gossip state for the period inbetween,
> which is why this is scheduled for 3.0. If there's a better option, though,
> it may make sense to put this in 2.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
