[ 
https://issues.apache.org/jira/browse/CASSANDRA-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353049#comment-14353049
 ] 

Branimir Lambov commented on CASSANDRA-5791:
--------------------------------------------

+1, with two nits:
[DataIntegrityMetadata 
115,125|https://github.com/jeffjirsa/cassandra/commit/89c1153def3f0ef0804d45883d12b09e04bb872d#diff-be889b1991c498fde94c039b5e327269R125]:
 This looks risky. As {{Verifier}} will not try to build a 
{{FileDigestValidator}} when the digest is not present, should we still have 
this special case?
[StandaloneVerifier 
126|https://github.com/jeffjirsa/cassandra/commit/89c1153def3f0ef0804d45883d12b09e04bb872d#diff-85d9fb1ffe8c937029e4ec870f662f6fR126]:
 You may want to exit with code 1 if {{hasFailed}} is true.

> A nodetool command to validate all sstables in a node
> -----------------------------------------------------
>
>                 Key: CASSANDRA-5791
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5791
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: sankalp kohli
>            Assignee: Jeff Jirsa
>            Priority: Minor
>         Attachments: cassandra-5791-patch-3.diff, cassandra-5791.patch-2
>
>
> CUrrently there is no nodetool command to validate all sstables on disk. The 
> only way to do this is to run a repair and see if it succeeds. But we cannot 
> repair the system keyspace. 
> Also we can run upgrade sstables but that re writes all the sstables. 
> This command should check the hash of all sstables and return whether all 
> data is readable all not. This should NOT care about consistency. 
> The compressed sstables do not have hash so not sure how it will work there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to