[ 
https://issues.apache.org/jira/browse/CASSANDRA-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353329#comment-14353329
 ] 

Yuki Morishita commented on CASSANDRA-8901:
-------------------------------------------

Thanks for review.
Updated my branch with fixes 
(https://github.com/yukim/cassandra/commit/0625e61066d1d14213bab648956a3dc93976fc78).

One thing that I didn't change is:

bq. Should we add more detail on which repairs failed rather than just firing 
w/message "Some repair failed"? We could capture the failed 
RepairSessionResult.range values and notify with errored token ranges to the 
listener (note: that may be redundant w/node's logs)

If range failed to repair, it sends message with its range info right away and 
client can look at it, so I thought it is redundant.

> Generalize progress reporting between tools and a server
> --------------------------------------------------------
>
>                 Key: CASSANDRA-8901
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8901
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 3.0
>
>
> Right now, {{nodetool repair}} uses its own method and JMX notification 
> message format to report progress of async operation call. As we are 
> expanding async call to other operations (CASSANDRA-7124), we should have 
> generalized way to report to clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to