[ 
https://issues.apache.org/jira/browse/CASSANDRA-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353381#comment-14353381
 ] 

T Jake Luciani commented on CASSANDRA-8709:
-------------------------------------------

Could you rebase this?

Couple more nits on looking at the changes:

  * Why is CompressedSequentialWriter.compressed no longer final?
  * In DeflateCompressor: WrappedByteBuffer might be Direct. For non-direct you 
should always be passing buffer.position() + buffer.arrayOffset() for current 
index of the array 

> Convert SequentialWriter from using RandomAccessFile to nio channel
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-8709
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8709
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>              Labels: Windows
>             Fix For: 3.0
>
>
> For non-mmap'ed I/O on Windows, using nio channels will give us substantially 
> more flexibility w/regards to renaming and moving files around while writing 
> them.  This change in conjunction with CASSANDRA-4050 should allow us to 
> remove the Windows bypass code in SSTableRewriter for non-memory-mapped I/O.
> In general, migrating from instances of RandomAccessFile to nio channels will 
> help make Windows and linux behavior more consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to