[
https://issues.apache.org/jira/browse/CASSANDRA-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355727#comment-14355727
]
Benjamin Lerer commented on CASSANDRA-7660:
-------------------------------------------
Just one minor nit:
* I think it would be probably better, in
{{allInSameCF(List<ColumnSpecification> names)}} to replace:
{quote}
if (names == null)
return false;
assert !names.isEmpty();
{quote}
by
{quote}
if (names == null || names.isEmpty())
return false;
{quote}
Otherwise, it is a +1 for me.
Thanks for splitting the review fixes in small commits.
> Indicate PK columns in "prepared" native protocol responses
> -----------------------------------------------------------
>
> Key: CASSANDRA-7660
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7660
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Tyler Hobbs
> Assignee: Tyler Hobbs
> Labels: protocolv4
> Fix For: 3.0
>
> Attachments: 7660-trunk-v2.txt, 7660-trunk.txt
>
>
> Currently, when native protocol drivers prepare statements, they need to
> check their internal representation of the schema to determine which, if any,
> of the columns are part of the partition key. If the native protocol
> response indicated this, it would remove the drivers' dependency on having an
> internal representation of the schema when preparing statements.
> This would need to go in the v4 protocol.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
