[
https://issues.apache.org/jira/browse/CASSANDRA-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379731#comment-14379731
]
Aleksey Yeschenko edited comment on CASSANDRA-8561 at 3/25/15 11:45 AM:
------------------------------------------------------------------------
Firstly, you've rebased incorrectly, overriding the changes of CASSANDRA-8559.
Secondly, you worry about key length here, while slices formatted could take
just as much, or much more, of the log space.
I'd just leave it be as is, except make {{boolean warnTombstones}} also take
{{logger.isWarnEnabled}} into account. Altogether this should give people a way
to at least disable the code path entirely by disabling logger preferences for
{{SliceQueryFilter}}.
500 feels extremely arbitrary to me. It's not even a nice round number. If you
do decide to truncate output, after all, pick a round one - maybe 256 or 512 -
and truncate the entire log message, not just the key.
Adding yet another config option, yaml or -D, is the last thing we need. Pick a
hardcoded one or don't truncate at all, one of the two.
was (Author: iamaleksey):
Firstly, you've rebased incorrectly, overriding the changes of CASSANDRA-8559.
Secondly, you worry about key length here, while slices formatted could take
just as much, or much less, of the log space.
I'd just leave it be as is, except make {{boolean warnTombstones}} also take
{{logger.isWarnEnabled}} into account. Altogether this should give people a way
to at least disable the code path entirely by disabling logger preferences for
{{SliceQueryFilter}}.
500 feels extremely arbitrary to me. It's not even a nice round number. If you
do decide to truncate output, after all, pick a round one - maybe 256 or 512 -
and truncate the entire log message, not just the key.
Adding yet another config option, yaml or -D, is the last thing we need. Pick a
hardcoded one or don't truncate at all, one of the two.
> Tombstone log warning does not log partition key
> ------------------------------------------------
>
> Key: CASSANDRA-8561
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8561
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Environment: Datastax DSE 4.5
> Reporter: Jens Rantil
> Assignee: Lyuben Todorov
> Labels: logging
> Fix For: 2.1.4
>
> Attachments: cassandra-2.1-1427196372-8561-v2.diff,
> cassandra-2.1-8561.diff, cassandra-2.1-head-1427124485-8561.diff,
> cassandra-trunk-head-1427125869-8561.diff, trunk-1427195046-8561-v2.diff
>
>
> AFAIK, the tombstone warning in system.log does not contain the primary key.
> See: https://gist.github.com/JensRantil/44204676f4dbea79ea3a
> Including it would help a lot in diagnosing why the (CQL) row has so many
> tombstones.
> Let me know if I have misunderstood something.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
