[
https://issues.apache.org/jira/browse/CASSANDRA-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486541#comment-14486541
]
Stefania commented on CASSANDRA-8962:
-------------------------------------
The patch is ready: https://github.com/stef1927/cassandra/commits/8962
The test passes on my box (Windows 7 and Ubuntu 14), provided the timeout is
long enough (e.g. 120000) - otherwise occasionally it may time out, just like
other tests.
At line 233 (testFileRemoval()) I had to comment out one assertion as it is not
possible to have those files deleted before writer.abort() is called, since it
holds a reference to the NIO channel via SegmentedFile.Builder. If you are also
happy dropping this assertion, please remove the commented out lines during
commit.
Also, I had to change some production code by manually releasing the new ss
tables in the compaction task when it is offline. Without this, the split ss
tables test leaves behind files that then cause the following tests to fail.
These files cannot be deleted until the sstables are garbage collected. I
suppose we could try to force a GC of those tables as an alternative but I
think ultimately we want to fix all leaks so I modified the compaction task
directly.
> Fix SSTableRewriterTest on Windows
> ----------------------------------
>
> Key: CASSANDRA-8962
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8962
> Project: Cassandra
> Issue Type: Bug
> Reporter: Joshua McKenzie
> Assignee: Stefania
> Priority: Trivial
> Labels: Windows
> Fix For: 3.0
>
>
> Platform specific failures:
> org.apache.cassandra.io.sstable.SSTableRewriterTest.testNumberOfFiles_truncate
> org.apache.cassandra.io.sstable.SSTableRewriterTest.testSmallFiles
> org.apache.cassandra.io.sstable.SSTableRewriterTest.testNumberOfFiles_dont_clean_readers
> org.apache.cassandra.io.sstable.SSTableRewriterTest.testNumberOfFiles_finish_empty_new_writer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
