[ https://issues.apache.org/jira/browse/CASSANDRA-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503102#comment-14503102 ]
Sergio Bossa commented on CASSANDRA-9196: ----------------------------------------- Thanks [~beobal], I've reviewed the 2.1 version, and even if I don't like to have two different methods basically doing the same thing, as this could lead to inconsistent implementations, there doesn't seem to be any other way, so LGTM. > Do not rebuild indexes if no columns are actually indexed > --------------------------------------------------------- > > Key: CASSANDRA-9196 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9196 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Sergio Bossa > Assignee: Sergio Bossa > Fix For: 2.0.15 > > Attachments: 2.0-CASSANDRA-9196.txt, 2.1-CASSANDRA-9196.txt > > > When rebuilding secondary indexes, the index task is executed regardless if > the actual {{SecondaryIndex#indexes(ByteBuffer )}} implementation of any > index returns true for any column, meaning that the expensive task of going > through all sstables and related rows will be executed even if in the end no > column/row will be actually indexed. > This is a huge performance hit when i.e. bootstrapping with large datasets on > tables having custom secondary index implementations whose {{indexes()}} > implementation might return false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)