[
https://issues.apache.org/jira/browse/CASSANDRA-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969894#action_12969894
]
Jonathan Ellis commented on CASSANDRA-1791:
-------------------------------------------
We should refactor this even more. The snapshot name should be 100% determined
by the caller of takeSnapshot, i.e. we shouldn't either (a) allow it to be null
or (b) append a timestamp to it.
We can leave nodetool to default to supplying a timestamp-based name, the
difference will be that each node will have the same snapshot path rather than
slightly different ones.
Also, I'd like it to take a String... tables parameter, to accept a list of
keyspaces to snapshot, defaulting to all on empty the way we've been
standardizing repair / cleanup / etc.
> Return name of snapshot directory after creating it
> ---------------------------------------------------
>
> Key: CASSANDRA-1791
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1791
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Environment: Debian Squeeze
> Reporter: paul cannon
> Assignee: Nick Bailey
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments:
> 0001-Use-same-timestamp-for-full-snapshots-and-return-sna.patch
>
>
> When making a snapshot, the new directory is created with a timestamp and,
> optionally, a user-supplied tag. For the sake of automated snapshot-creating
> tools, it would be helpful to know unequivocally what the new snapshot
> directory was named (otherwise, the tool must search for a directory similar
> what it expects the name to be, which could be both error-prone and maybe
> susceptible to attack).
> Recommend making takeSnapshot and takeAllSnapshot return a string, which is
> the base component of the new snapshot's directory name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
