[
https://issues.apache.org/jira/browse/CASSANDRA-8897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514700#comment-14514700
]
Benedict commented on CASSANDRA-8897:
-------------------------------------
Hmm. RandomAccessReader the only instances of this? If so could we just grab
our buffer in {{reBuffer()}}?
If not, we should probably remove the logging altogether, or downgrade to
DEBUG. We behave more optimally without sharing, but we also cope with it
gracefully, so we should have some periodic review to ensure we're doing our
best to avoid sharing, but we shouldn't probably consider it an error. I was
initially a little concerned about having multiple operations with different
lifetimes sharing a chunk, but really the chunks are very small, so it's not a
big deal if their free only occurs at the end of the slowest operation. Only a
single cross-over chunk can be affected per such operation, so it's not a lot
to worry about unless there are many such operations and their lifetimes are
highly varied.
> Remove FileCacheService, instead pooling the buffers
> ----------------------------------------------------
>
> Key: CASSANDRA-8897
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8897
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Stefania
> Fix For: 3.0
>
>
> After CASSANDRA-8893, a RAR will be a very lightweight object and will not
> need caching, so we can eliminate this cache entirely. Instead we should have
> a pool of buffers that are page-aligned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
