[ 
https://issues.apache.org/jira/browse/CASSANDRA-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521034#comment-14521034
 ] 

Stefania commented on CASSANDRA-9140:
-------------------------------------

Thanks for your feedback.

bq. Unless I'm missing something, it looks like the retry doesn't actually use 
the data size or position from the index. It seems like the intent is to try to 
read the data based on the Data component's position and size (if present) 
first, and if that fails, use the position and size from the index.

I think you are absolutely correct, I've added a seek to the position read from 
the index.

I've addressed all other comments as well, in all 3 patches, which have also 
been rebased.

Finally, I added a couple more utests to increase code coverage but only 
without compression as I would not know how to achieve the same with 
compression.

> Scrub should handle corrupted compressed chunks
> -----------------------------------------------
>
>                 Key: CASSANDRA-9140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9140
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Assignee: Stefania
>             Fix For: 2.1.x, 2.0.x
>
>
> Scrub can handle corruption within a row, but can't handle corruption of a 
> compressed sstable that results in being unable to decompress a chunk.  Since 
> the majority of Cassandra users are probably running with compression 
> enabled, it's important that scrub be able to handle this (likely more 
> common) form of sstable corruption.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to