[
https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528047#comment-14528047
]
Stefania commented on CASSANDRA-7066:
-------------------------------------
Thank you for your comments, I've pushed a new commit addressing them. I also
did a bit of renaming and decomposition, the class is now called
*SSTableOperation* although perhaps it should be called something that better
conveys the meaning of "transaction involving a group of sstables", so either
*SSTableTransaction* or *SSTablesTransaction*. Any ideas?
To force the sync of the directory's file descriptor I used the CLibrary
methods, I hope that is correct.
The notification approach has changed completely and is now based on a
reference released by a runOnClose, like you suggested. DescriptoryTypeTidy and
GlobalTidy are merged into one.
I still need to work on fixing the broken tests and implementing the standalone
tool.
> Simplify (and unify) cleanup of compaction leftovers
> ----------------------------------------------------
>
> Key: CASSANDRA-7066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7066
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Stefania
> Priority: Minor
> Labels: compaction
> Fix For: 3.x
>
>
> Currently we manage a list of in-progress compactions in a system table,
> which we use to cleanup incomplete compactions when we're done. The problem
> with this is that 1) it's a bit clunky (and leaves us in positions where we
> can unnecessarily cleanup completed files, or conversely not cleanup files
> that have been superceded); and 2) it's only used for a regular compaction -
> no other compaction types are guarded in the same way, so can result in
> duplication if we fail before deleting the replacements.
> I'd like to see each sstable store in its metadata its direct ancestors, and
> on startup we simply delete any sstables that occur in the union of all
> ancestor sets. This way as soon as we finish writing we're capable of
> cleaning up any leftovers, so we never get duplication. It's also much easier
> to reason about.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
