[ 
https://issues.apache.org/jira/browse/CASSANDRA-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530097#comment-14530097
 ] 

Marcus Eriksson commented on CASSANDRA-5839:
--------------------------------------------

I actually think it is the correct solution (or, not doing it immediately after 
since we sometimes access the stdout when running verbose).

If we don't do process.communicate() the console output from the java process 
can fill up the subprocess buffer (note, the only reference I have found that 
this can happen is a stackoverflow comment: 
http://stackoverflow.com/questions/14735001/ignoring-output-from-subprocess-popen#comment20619366_14735020).
 Then we wait for the *log file* to print the "node is now UP" message which 
won't happen if the java process is blocked on printing to the console

This patch to ccm fixes the issue: 
https://github.com/krummas/ccm/commit/f788b446e4ea877e145a19e138edbd10931dff62

> Save repair data to system table
> --------------------------------
>
>                 Key: CASSANDRA-5839
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5839
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core, Tools
>            Reporter: Jonathan Ellis
>            Assignee: Marcus Eriksson
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 0001-5839.patch, 2.0.4-5839-draft.patch, 
> 2.0.6-5839-v2.patch
>
>
> As noted in CASSANDRA-2405, it would be useful to store repair results, 
> particularly with sub-range repair available (CASSANDRA-5280).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to