[
https://issues.apache.org/jira/browse/CASSANDRA-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540279#comment-14540279
]
Tyler Hobbs commented on CASSANDRA-9299:
----------------------------------------
+1 overall, with just a couple of minor comments. In the 2.1 patch, this
comment should say "will be immediately discarded" instead of "will _not_ be
immediately discarded":
{code}
// An expired tombstone will not be immediately discarded in memory, and
needn't be counted.
{code}
Also, the
{{paging_test.TestPagingWithDeletions.test_failure_threshold_deletions()}}
dtest needs to be updated, since it's relying on partition-level deletions
triggering the failure threshold.
> Fix counting of tombstones towards TombstoneOverwhelmingException
> -----------------------------------------------------------------
>
> Key: CASSANDRA-9299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9299
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Fix For: 2.1.x, 2.0.x
>
> Attachments: 9299-2.0.txt, 9299-2.1.txt, 9299-trunk.txt
>
>
> CASSANDRA-6042 introduced warning on too many tombstones scanned, then
> CASSANDRA-6117 introduced a hard TombstoneOverwhelmingException condition.
> However, at least {{SliceQuerFilter.collectReducedColumn()}} seems to have
> the logic wrong. Cells that are covered by a range tombstone or a partition
> high level deletion, still count towards {{ColumnCounter}}'s {{ignored}}
> register.
> Thus it's possible to have an otherwise healthy (though large) dropped
> partition read cause an exception that shouldn't be there.
> The only things that should count towards the exception are cell tombstones
> and range tombstones (CASSANDRA-8527), but never ever live cells shadowed by
> any kind of tombstone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
