[
https://issues.apache.org/jira/browse/CASSANDRA-9300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541546#comment-14541546
]
Stefania edited comment on CASSANDRA-9300 at 5/13/15 7:49 AM:
--------------------------------------------------------------
Hi Robert, some issues with the murmur ranges which did not match, i.e. the
defaults and the option callback values where different. I believe the correct
range is -2^63 to 2^63-1 or at least these are the MIN and MAX of murmur
partitioner in java. Please confirm. I also updated the description. All
changes here: https://github.com/stef1927/cassandra/commits/9300-token-gen
For the dtests, there was a tiny bug, please see here:
https://github.com/stef1927/cassandra-dtest/commits/9300-token-gen
For convenience I created a pull request to you
(https://github.com/snazy/cassandra-dtest/pull/1) but for some reason I could
not do the same for the cassandra branch.
I believe you can create a pull request of your dtests to the riptano branch as
soon as you like, provided you use the 'require' tag that you see in my PR.
Then when the JIRA is committed you ask them to remove the require tag, else
just wait till the JIRA is committed and create the PR afterwards, without the
require tag.
was (Author: stefania):
Hi Robert, some issues with the murmur ranges which did not match, i.e. the
defaults and the option callback values where different. I believe the correct
range is -2^63 to 2^63-1 or at least these are the MIN and MAX of murmur
partitioner in java. Please confirm. I also updated the description. All
changes here: https://github.com/stef1927/cassandra/commits/9300-token-gen
For the dtests, there was a tiny bug, please see here:
https://github.com/stef1927/cassandra-dtest/commits/9300-token-gen
For convenience I created a pull request to you
(https://github.com/snazy/cassandra-dtest/pull/1) but for some reason I could
not do the same for the cassandra branch.
I believe you can created a pull request of your dtests to the riptano branch
as soon as you like, provided you use the 'require' tag that you see in my PR.
Then when the JIRA is committed you ask them to remove the require tag, else
just wait till the JIRA is committed and create the PR afterwards, without the
require tag.
> token-generator - generated tokens too long
> -------------------------------------------
>
> Key: CASSANDRA-9300
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9300
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 3.x, 2.1.x, 2.0.x
>
> Attachments: 9300-v2.txt, 9300.txt
>
>
> {{token-generator}} tool does not generate valid long values (2.0, 2.1,
> trunk).
> E.g.
> {code}
> tools/bin/token-generator 4
> DC #1:
> Node #1: 0
> Node #2: 42535295865117307932921825928971026432
> Node #3: 85070591730234615865843651857942052864
> Node #4: 127605887595351923798765477786913079296
> {code}
> But should generate tokens like
> {code}
> -9223372036854775808
> -4611686018427387904
> 0
> 4611686018427387904
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
