[ https://issues.apache.org/jira/browse/CASSANDRA-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559253#comment-14559253 ]
Jeremiah Jordan commented on CASSANDRA-9438: -------------------------------------------- +1 testall is clean: http://cassci.datastax.com/view/z_All/job/yukim-9438-trunk-testall/lastCompletedBuild/testReport/ dtest has some failures, but they do not look related to this: http://cassci.datastax.com/view/z_All/job/yukim-9438-trunk-dtest/lastCompletedBuild/testReport/ > Repair version gating will do the wrong thing in rc/beta dev builds > ------------------------------------------------------------------- > > Key: CASSANDRA-9438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9438 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Jeremiah Jordan > Assignee: Yuki Morishita > Fix For: 2.2.0 rc1 > > Attachments: > 0001-Support-SNAPSHOT-in-CassandraVersion-formerly-Semant.patch > > > The version check gate in AnticompactionTask will fail with -betaX-SNAPSHOT > and -rcX-SNAPSHOT builds. As SystemKeyspace.getReleaseVersion will return > null for those. This means dtests and anyone else testing with dev builds > will be getting the wrong repair behavior. > [AnticompactionTask.java|https://github.com/apache/cassandra/blob/a583f70eeeada31478a55b5774ef222c55956220/src/java/org/apache/cassandra/repair/AnticompactionTask.java#L59] > {code} > SemanticVersion peerVersion = > SystemKeyspace.getReleaseVersion(neighbor); > if (peerVersion != null && peerVersion.compareTo(VERSION_CHECKER) > 0) > { > MessagingService.instance().sendRR(acr.createMessage(), neighbor, > new AnticompactionCallback(this), TimeUnit.DAYS.toMillis(1), true); > } > else > { > MessagingService.instance().sendOneWay(acr.createMessage(), > neighbor); > // immediately return after sending request > set(neighbor); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)