[
https://issues.apache.org/jira/browse/CASSANDRA-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567618#comment-14567618
]
Joshua McKenzie commented on CASSANDRA-9342:
--------------------------------------------
In CompactionStrategyManager.getCompactionTask, why accept a Set<SSTableReader>
when we only have the 1 caller that has to Collections.singleton() to match the
signature?
Comment in WrappingCompactionStrategy appears incorrect re:
filterSSTablesForReads:
{noformat}
/**
* TODO: remove, unused
*/
{noformat}
The method is referenced in a couple of places.
Fix spacing and comment why 15 in
CompactionStrategyManager.getSSTableCountPerLevel:
{noformat}
int [] res = new int[15]
{noformat}
As a sanity check, I went ahead and ran unit tests on Windows and they look
good.
With the above minor changes / nits, I'm +1. Clean refactor.
> Remove WrappingCompactionStrategy
> ---------------------------------
>
> Key: CASSANDRA-9342
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9342
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Minor
> Fix For: 3.x
>
>
> We should remove the WrappingCompactionStrategy as it is quite confusing (ie,
> not being a real compaction strategy that you can select when creating a
> table)
> It should be renamed and stop extending AbstractCompactionStrategy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
