[ 
https://issues.apache.org/jira/browse/CASSANDRA-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972351#action_12972351
 ] 

Hudson commented on CASSANDRA-1265:
-----------------------------------

Integrated in Cassandra-0.6 #26 (See 
[https://hudson.apache.org/hudson/job/Cassandra-0.6/26/])
    make compaction buckets deterministic
patch by thobbs; reviewed by jbellis for CASSANDRA-1265


> make getBuckets deterministic
> -----------------------------
>
>                 Key: CASSANDRA-1265
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1265
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Tyler Hobbs
>            Priority: Minor
>             Fix For: 0.6.9, 0.7 beta 1
>
>         Attachments: cassandra-0.6-1265.txt, cassandra-0.6-1265.txt
>
>
> CompactionManager.getBuckets is nondeterministic as explained in the parent 
> issue.
> This can be fixed either by sorting in getBuckets, or requiring that the 
> iterable passed be sorted already.  Either is fine.
> We also need to add some unit tests to CompactionManagerTest for getBuckets.  
> We need to decouple getBuckets a little to do this sanely; rather than 
> examining sstable length directly or introducing some extra interface, let's 
> declare getBuckets as
>     static Set<List<T>> getBuckets(Iterable<Pair<T, Integer>> files, long min)
> where the integer in the pair is the file size.  Then you can write tests 
> against Strings instead of SSTableReaders.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to