[ 
https://issues.apache.org/jira/browse/CASSANDRA-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593349#comment-14593349
 ] 

Sylvain Lebresne commented on CASSANDRA-9618:
---------------------------------------------

As said in the description, I think we should at least deprecate json2sstable. 
Regarding sstable2json, my preference would be to replace it with a tool that 
makes it clear that the purpose is to debug sstable and that is tailored to 
that need. In particular, even though we could preserve a json output for the 
sake of tools that would want to consume the output, I suspect that we can do 
something more readable for human beings (and having multiple outputs wouldn't 
be that hard if we design it correctly). I also think it could be useful to 
have the output optionally include the offset in the file of the different 
elements (always for the sake of debugging), etc.... We could do all of this 
and still call the tool sstable2json, but if it's gonna break anyone using the 
sstable2json tool, I'd rather just have it be a new tool with a more 
appropriate name (something like 'sstableInspector' or whatnot). Doing so (and 
thus deprecating sstable2json) also give us a little bit more flexibility as to 
when we introduce the new tool. I'd love to see that new tool in 3.0 and 
hopefully it will be (it's not all that much work in the first place), but if 
push comes to shove only having it in 3.1/3.2 doesn't sound like the end of the 
world to me.

> Consider deprecating sstable2json/json2sstable in 2.2
> -----------------------------------------------------
>
>                 Key: CASSANDRA-9618
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9618
>             Project: Cassandra
>          Issue Type: Task
>            Reporter: Sylvain Lebresne
>             Fix For: 2.2.0 rc2
>
>
> The rational is explained in CASSANDRA-7464 but to rephrase a bit:
> * json2sstable is pretty much useless, {{CQLSSTableWriter}} is way more 
> flexible if you need to write sstable directly.
> * sstable2json is really only potentially useful for debugging, but it's 
> pretty bad at that (it's output is not really all that helpul in modern 
> Cassandra in particular).
> Now, it happens that updating those tool for CASSANDRA-8099, while possible, 
> is a bit involved. So I don't think it make sense to invest effort in 
> maintain these tools. So I propose to deprecate these in 2.2 with removal in 
> 3.0.
> I'll note that having a tool to help debugging sstable can be useful, but I 
> propose to add a tool for that purpose with CASSANDRA-7464.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to