[
https://issues.apache.org/jira/browse/CASSANDRA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973196#action_12973196
]
Jonathan Ellis commented on CASSANDRA-1886:
-------------------------------------------
I'm nervous that ignoring exceptions entirely could eliminate a source of
information when things are breaking. I suggest creating a
FBUtilities.closeQuietly that does a logger.warn on exception.
Minor point: to match the rest of the code, use spaces for indentation, not
tabs.
> [patch] Make sure sterams get closed
> ------------------------------------
>
> Key: CASSANDRA-1886
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1886
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: close_files.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Various places in the code either don't close the streams they open, or only
> close them in success cases. Moved close operations to finally blocks, and
> use commons-io to quiet the close operations (IOUtils.closeQuietly)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
