[ 
https://issues.apache.org/jira/browse/CASSANDRA-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601694#comment-14601694
 ] 

Ariel Weisberg commented on CASSANDRA-9293:
-------------------------------------------

We want to solve this for all unit tests not just one at a time. So we should 
look for the output from 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/concurrent/Ref.java
 
from
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/CassandraXMLJUnitResultFormatter.java
and
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/CassandraBriefJUnitResultFormatter.java

I am also not sure how you are finding the log files? This is looking for the 
logs from a previous test?

> Unit tests should fail if any LEAK DETECTED errors are printed
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-9293
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9293
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Sylvestor George
>              Labels: test
>         Attachments: 9293.txt
>
>
> We shouldn't depend on dtests to inform us of these problems (which have 
> error log monitoring) - they should be caught by unit tests, which may also 
> cover different failure conditions (besides being faster).
> There are a couple of ways we could do this, but probably the easiest is to 
> add a static flag that is set to true if we ever see a leak (in Ref), and to 
> just assert that this is false at the end of every test.
> [~enigmacurry] is this something TE can help with?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to