[ https://issues.apache.org/jira/browse/CASSANDRA-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610782#comment-14610782 ]
Aleksey Yeschenko commented on CASSANDRA-8384: ---------------------------------------------- Overall mostly looks good, with some issues and nits. Nits: - CHANGES.txt entries should be short. Ideally a single line, no longer than 80 characters or so. - this particular message belongs to NEWS.txt, Upgrading section Issues: - {{CompressionParameters.asThriftOptions()}} should remain unchanged (use the old keys. not include {{enabled}}) - {{CompressionParameters.create()}} should not reject {{enabled}} set to {{true}} and a presence of {{class}} - it should be allowed, there is no conflict there - however, if {{enabled}} is set to {{false}}, we should reject any other options being set. And do the same for {{compaction}} (in a separate ticket) - even when disabled, we should still store the map with {{'enabled': 'false'}} in the schema table > Change CREATE TABLE syntax for compression options > -------------------------------------------------- > > Key: CASSANDRA-8384 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8384 > Project: Cassandra > Issue Type: Sub-task > Reporter: Aleksey Yeschenko > Assignee: Benjamin Lerer > Labels: doc-impacting, docs > Fix For: 3.x > > > Currently, `compression` table options are inconsistent with the likes of it > (table `compaction`, keyspace `replication`). > I suggest we change it for 3.0, like we did change `caching` syntax for 2.1 > (while continuing to accept the old syntax for a release). > I recommend the following changes: > 1. rename `sstable_compression` to `class`, to make it consistent > `compression` and `replication` > 2. rename `chunk_length_kb` to `chunk_length_in_kb`, to match > `memtable_flush_period_in_ms`, or, alternatively, to just `chunk_length`, > with `memtable_flush_period_in_ms` renamed to `memtable_flush_period` - > consistent with every other CQL option everywhere else > 3. add a boolean `enabled` option, to match `compaction`. Currently, the > official way to disable comression is an ugly, ugly hack (see CASSANDRA-8288) -- This message was sent by Atlassian JIRA (v6.3.4#6332)