[ 
https://issues.apache.org/jira/browse/CASSANDRA-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610908#comment-14610908
 ] 

Benedict commented on CASSANDRA-9701:
-------------------------------------

Hmm. I'm not sure why, but I think I was thinking of them as like clustering 
columns and only taking frozen types.

Well, I'm relatively easy. At least I think we should enforce the isComplex() 
check before the others, since we depend so strongly on it. However since these 
comparison methods will probably be one of the main intra-node CPU time sinks, 
it's probably worth incurring the slight ugliness of STATIC_SIMPLE and 
STATIC_COMPLEX to merge both of those checks into the kind comparison.

> Split Kind.REGULAR into SIMPLE and COMPLEX
> ------------------------------------------
>
>                 Key: CASSANDRA-9701
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9701
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> A small refactor as follow up to 8099. By splitting SIMPLE and COMPLEX into 
> their own Kind, we can simplify the compareTo method and obtain greater 
> certainty that we don't (now or in future) accidentally break the required 
> sort order that simple << complex.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to