[
https://issues.apache.org/jira/browse/CASSANDRA-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611830#comment-14611830
]
Branimir Lambov commented on CASSANDRA-9656:
--------------------------------------------
The code looks good. As the biggest issue is various runOnClose runnables
holding references through their closure, I would add JavaDoc or comment to the
relevant methods (cloneWithNewStart, cloneAsShadowed, possibly others) as well
as InstanceTidier.runOnClose to warn about it.
{{DataTracker.getCurrentVersion(sstable)}} could be implemented as
{{view.get().sstablesMap.get(sstable)}}.
> Strong circular-reference leaks
> -------------------------------
>
> Key: CASSANDRA-9656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9656
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Priority: Critical
> Fix For: 2.1.8
>
>
> As discussed in CASSANDRA-9423, we are leaking references to the ref-counted
> object into the Ref.Tidy, so that they remain strongly reachable,
> significantly limiting the value of the leak detection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
