[ 
https://issues.apache.org/jira/browse/CASSANDRA-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629996#comment-14629996
 ] 

Yuki Morishita commented on CASSANDRA-7357:
-------------------------------------------

I like the approache and overall patch looks good.
[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-7357-2.1-testall/5/]
 and 
[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-7357-2.1-dtest/2/]
 seem good too.

One thing that I suggest is doing {{clearEphemeralSnapshots}} inside 
{{ColumnFamilyStore.scrubDataDirectories}} before actually opening tables.
That way the code will look more orgazined.

> Cleaning up snapshots on startup leftover from repairs that got interrupted
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-7357
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7357
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Stephen Johnson
>            Assignee: Paulo Motta
>            Priority: Minor
>             Fix For: 2.1.x
>
>
> When a repair is interrupted, such as a restart, it can leave a snapshot 
> behind on disk.  These could be checked for and cleared possibly on startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to