[
https://issues.apache.org/jira/browse/CASSANDRA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631743#comment-14631743
]
Sylvain Lebresne commented on CASSANDRA-9705:
---------------------------------------------
I've pushed an additional commit to the branch that refactor the {{Reader}} in
{{SSTableIterator}} and {{SSTableReverseIterator}}. The new implementations
directly return the reader for the {{slice}} method, but more generally avoid
pretty much all the code duplication there was (and is simpler/cleaner as a
result).
bq. There are some unused imports around the place
Forgot to answer that one. I don't know a good way to find those imports that
are unused due to this patch (and looking manually is not very fun), so if
we're good with it, I propose to just run an import reorganization on the
project on commit.
> Simplify some of 8099's concrete implementations
> ------------------------------------------------
>
> Key: CASSANDRA-9705
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9705
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 3.0 beta 1
>
>
> As mentioned in the ticket comments, some of the concrete implementations
> (for Cell, Row, Clustering, PartitionUpdate, ...) of the initial patch for
> CASSANDRA-8099 are more complex than they should be (the use of flyweight is
> typically probably ill-fitted), which probably has performance consequence.
> This ticket is to track the refactoring/simplifying those implementation
> (mainly by removing the use of flyweights and simplifying accordingly).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
