[ 
https://issues.apache.org/jira/browse/CASSANDRA-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637260#comment-14637260
 ] 

Joshua McKenzie edited comment on CASSANDRA-9869 at 7/22/15 5:41 PM:
---------------------------------------------------------------------

Test was committed failing on Windows by CASSANDRA-7357. There was expected 
state in the WindowsFailedSnapshotTracker that wasn't setup tripping this 
assertion, and when that state is initialized the test fails as it's expecting 
snapshots to be off-disk when delete is requested. Given memory-mapped files on 
Windows we can't guarantee those snapshots will be deleted until either JVM 
shutdown or next C* start.

This is all moot as we don't use ephemeral snapshots on Windows since we don't 
allow snapshot-based repair. Trivial patch attached that skips this test on 
Windows with a comment as to why.



was (Author: joshuamckenzie):
Test was committed failing on Windows by CASSANDRA-7357. There was expected 
state in the WindowsFailedSnapshotTracker that wasn't setup tripping this 
assertion, and when that state is initialized the test fails as it's expecting 
snapshots to be off-disk when delete is requested. Given memory-mapped files on 
Windows we can't guarantee those snapshots will be delete until either JVM 
shutdown or next C* start.

This is all moot as we don't use ephemeral snapshots on Windows since we don't 
allow snapshot-based repair. Trivial patch attached that skips this test on 
Windows with a comment as to why.


> windows - failed testClearEphemeralSnapshots
> --------------------------------------------
>
>                 Key: CASSANDRA-9869
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9869
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Trivial
>              Labels: Windows
>             Fix For: 2.2.x
>
>         Attachments: 9869.txt
>
>
> Did some juggling to get the state cleared/prepped when I wrote the test but 
> apparently it's intermittently failing with the following:
> {noformat}
> junit.framework.AssertionFailedError
>       at 
> org.apache.cassandra.db.WindowsFailedSnapshotTracker.handleFailedSnapshot(WindowsFailedSnapshotTracker.java:104)
>       at 
> org.apache.cassandra.db.Directories.clearSnapshot(Directories.java:741)
>       at 
> org.apache.cassandra.db.ColumnFamilyStore.clearEphemeralSnapshots(ColumnFamilyStore.java:2343)
>       at 
> org.apache.cassandra.db.ColumnFamilyStoreTest.testClearEphemeralSnapshots(ColumnFamilyStoreTest.java:1555)
> {noformat}
> I assume it's something trivial (having not yet looked into it at all).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to