[
https://issues.apache.org/jira/browse/CASSANDRA-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637464#comment-14637464
]
Jim Witschey commented on CASSANDRA-9774:
-----------------------------------------
After having a look at this, I still don't understand what the correct behavior
should be. [~tjake] It looks like you wrote {{sstableverify}}, based on [this
commit|https://github.com/apache/cassandra/commit/2d7909dc12dc038a65742ca03d375140c5257158]?
Could you please have a look to see if the test was testing for the correct
behavior, and what it should be testing for now? And if not, could you let me
know who might be able to? Thanks.
> fix sstableverify dtest
> -----------------------
>
> Key: CASSANDRA-9774
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9774
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jim Witschey
> Priority: Blocker
> Fix For: 3.0.x
>
>
> One of our dtests for {{sstableverify}}
> ({{offline_tools_test.py:TestOfflineTools.sstableverify_test}}) is failing
> hard on trunk ([cassci
> history|http://cassci.datastax.com/view/trunk/job/trunk_dtest/lastCompletedBuild/testReport/offline_tools_test/TestOfflineTools/sstableverify_test/history/])
> The way the test works is by deleting an SSTable, then running
> {{sstableverify}} on its table. In earlier versions, it successfully detects
> this problem and outputs that it "was not released before the reference was
> garbage collected". The test no longer finds this string in the output;
> looking through the output of the test, it doesn't look like it reports any
> problems at all.
> EDIT: After digging into the C* source a bit, I may have misattributed the
> problem to {{sstableverify}}; this could be a more general memory management
> problem, as the error text expected in the dtest is emitted by part of the
> {{Ref}} implementation:
> https://github.com/apache/cassandra/blob/075ff5000ced24b42f3b540815cae471bee4049d/src/java/org/apache/cassandra/utils/concurrent/Ref.java#L187
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
