[
https://issues.apache.org/jira/browse/CASSANDRA-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Burroughs updated CASSANDRA-9872:
---------------------------------------
Description:
If the KeyCache exists (because at least one column family is using it) we
currenlty check the key cache even for requests to column families where the
key cache is disabled. I think it would be better to only check the cache if
entries *could* be there.
* This will align the key cache with how the row cache behaves.
* This makes the key cache metrics much more useful. For example, 'requests'
becomes 'requests to things that could be in the key cache' and not just 'total
requests'.
* This migh be a micro-optimization saving a few metric update.
was:
If the KeyCache exists (because at least one column family is using it) we
currenlty check the key cache even for requests to column families where the
key cache is disabled. I think it would be better to only check the cache if
entries *could* be there.
* This will align the key cache with how the row cache behaves.
* This makes the key cache metrics much more useful. For example, 'requests'
becomes 'requests to things that could be in the key cache' and not just 'total
requests'.
* This migh be a micro-optimization saving a few metric update.
only count 'hit-able' requests as key cache misses
> only check KeyCache when it is enabled
> --------------------------------------
>
> Key: CASSANDRA-9872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9872
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Chris Burroughs
> Assignee: Chris Burroughs
> Labels: cache, metrics
> Attachments: j9872-2.0-v1.txt
>
>
> If the KeyCache exists (because at least one column family is using it) we
> currenlty check the key cache even for requests to column families where the
> key cache is disabled. I think it would be better to only check the cache if
> entries *could* be there.
> * This will align the key cache with how the row cache behaves.
> * This makes the key cache metrics much more useful. For example,
> 'requests' becomes 'requests to things that could be in the key cache' and
> not just 'total requests'.
> * This migh be a micro-optimization saving a few metric update.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
