[ 
https://issues.apache.org/jira/browse/CASSANDRA-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652056#comment-14652056
 ] 

Paulo Motta edited comment on CASSANDRA-9941 at 8/3/15 4:22 PM:
----------------------------------------------------------------

The ccm bug is fixed by this merged 
[PR|https://github.com/pcmanus/ccm/pull/343]. Actually the {{$CASSANDRA_HOME}} 
and {{$CASSANDRA_CONF}} was not being exported, so the defaults were being 
picked by cassandra.in.bat (on Linux this was handled correctly by the 
ccm-modified cassandra.in.sh). Also, there was a problem with cassandra.in.bat 
that was not using the {{$CASSANDRA_CONF}} variable, so this 
[commit|https://github.com/apache/cassandra/commit/e93b86c2b3fb1bef33900d2c24427852044e2e54]
 fixes this.

The wrong return code was happening because the java error code was not being 
correctly exported by {{sstableverify.bat}}. This [2.2 
patch|https://github.com/pauloricardomg/cassandra/tree/9941-2.2] fixes the 
problem.


was (Author: pauloricardomg):
The ccm bug is fixed by this merged 
[PR|https://github.com/riptano/cassandra-dtest/pull/434]. Actually the 
{{$CASSANDRA_HOME}} and {{$CASSANDRA_CONF}} was not being exported, so the 
defaults were being picked by cassandra.in.bat (on Linux this was handled 
correctly by the ccm-modified cassandra.in.sh). Also, there was a problem with 
cassandra.in.bat that was not using the {{$CASSANDRA_CONF}} variable, so this 
[commit|https://github.com/apache/cassandra/commit/e93b86c2b3fb1bef33900d2c24427852044e2e54]
 fixes this.

The wrong return code was happening because the java error code was not being 
correctly exported by {{sstableverify.bat}}. This [2.2 
patch|https://github.com/pauloricardomg/cassandra/tree/9941-2.2] fixes the 
problem.

> SSTableVerify has wrong return codes on windows
> -----------------------------------------------
>
>                 Key: CASSANDRA-9941
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9941
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Philip Thompson
>            Assignee: Joshua McKenzie
>             Fix For: 2.2.x
>
>
> The dtest {{offline_tools_test.py:TestOfflineTools.sstableverify_test}} is 
> failing on windows. When running sstableverify.bat on a nonexistent keyspace, 
> the correct error message is printed, but an error code of 0 for success is 
> returned, which does not match the correct behavior on linux, which returns 1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to